fix: channel id might be null #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove4
bot
requested review from
CodeWithSwastik,
Dorukyum,
ChickenDevs,
FrostByte266,
VincentRPS,
Middledot,
WhoIsConch,
plun1331 and
BobDotCom
|
Reason for this fix: discord just send a gateway payload where the channel id was null and it yeeted a fucking cluster |
Lulalaby
removed request for
FrostByte266,
CodeWithSwastik,
WhoIsConch and
VincentRPS
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2078 +/- ##
==========================================
- Coverage 33.14% 33.14% -0.01%
==========================================
Files 97 97
Lines 19126 19129 +3
==========================================
Hits 6340 6340
- Misses 12786 12789 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
BobDotCom
requested changes
May 19, 2023
BobDotCom
previously requested changes
May 19, 2023
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com> Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Dorukyum
previously approved these changes
May 19, 2023
Signed-off-by: Lala Sabathil <lala@pycord.dev>
OmLanke
reviewed
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.