fix: add defaults to __init__s on embed classes #2061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2052 Signed-off-by: plun1331 <49261529+plun1331@users.noreply.github.com>
pullapprove4
bot
requested review from
BobDotCom,
ChickenDevs,
CodeWithSwastik,
Dorukyum,
FrostByte266,
Lulalaby,
Middledot,
VincentRPS and
WhoIsConch
Signed-off-by: plun1331 <49261529+plun1331@users.noreply.github.com>
|
pullapprove requesting literally everyone for review |
|
(i tested) |
Lulalaby
approved these changes
May 9, 2023
OmLanke
added a commit
to OmLanke/pycord
that referenced
this pull request
May 9, 2023
…opment#2061)" This reverts commit 6adc336.
Lulalaby
added a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2052
Alternatively, add a different method that converts it from a dict to the class, to emphasise the defaulted parameters actually being required when sent to Discord
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.