fix: Restore overriding on_application_command_error via listener #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes please update the changelog with info that this is a fix |
Lulalaby
added
bug
Lulalaby
previously approved these changes
May 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2044 +/- ##
==========================================
- Coverage 33.24% 33.23% -0.01%
==========================================
Files 97 97
Lines 19036 19038 +2
==========================================
Hits 6328 6328
- Misses 12708 12710 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
|
Geez fuck off pre commit bot |
Lulalaby
removed
the
hold: changelog
Lulalaby
previously approved these changes
May 4, 2023
|
Mhh seems like readthedocs is completely broken. I'm gonna look into that after I've slept. |
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Lulalaby
approved these changes
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts an out of scope change made in #1907 so the default
on_application_command_errorwon't fire if listeners for it exist.Side note: should changelog be updated for this?
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.