Skip to content

Conversation

@Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Feb 9, 2023

Summary

Adds a parameter called silent which applies the MessageFlags.suppress_notifications flag.
Also fixes minor inconsistencies in flag documentation.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Dorukyum Dorukyum added priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Feb 9, 2023
@Dorukyum Dorukyum added this to the v2.4 milestone Feb 9, 2023
@Dorukyum Dorukyum self-assigned this Feb 9, 2023
@Dorukyum Dorukyum requested a review from a team as a code owner February 9, 2023 10:26
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #1913 (34b7194) into master (e18d571) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1913   +/-   ##
=======================================
  Coverage   33.33%   33.33%           
=======================================
  Files          97       97           
  Lines       18753    18753           
=======================================
  Hits         6252     6252           
  Misses      12501    12501           
Flag Coverage Δ
macos-latest-3.10 33.32% <0.00%> (ø)
macos-latest-3.11 33.32% <0.00%> (ø)
macos-latest-3.8 33.33% <0.00%> (ø)
macos-latest-3.9 33.33% <0.00%> (ø)
ubuntu-latest-3.10 33.32% <0.00%> (ø)
ubuntu-latest-3.11 33.32% <0.00%> (ø)
ubuntu-latest-3.8 33.33% <0.00%> (ø)
ubuntu-latest-3.9 33.33% <0.00%> (ø)
windows-latest-3.10 33.32% <0.00%> (ø)
windows-latest-3.11 33.32% <0.00%> (ø)
windows-latest-3.8 33.33% <0.00%> (ø)
windows-latest-3.9 33.33% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/abc.py 22.33% <0.00%> (ø)
discord/flags.py 76.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e18d571...34b7194. Read the comment docs.

@Lulalaby Lulalaby enabled auto-merge (squash) February 9, 2023 13:18
@Lulalaby Lulalaby requested a review from ChickenDevs February 9, 2023 13:18
@Lulalaby Lulalaby merged commit a5982b9 into Pycord-Development:master Feb 9, 2023
@Dorukyum Dorukyum deleted the suppress-notifs-param branch January 25, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants