Skip to content

Conversation

@JustaSqu1d
Copy link
Member

@JustaSqu1d JustaSqu1d commented Feb 9, 2023

Summary

discord/discord-api-docs#5910

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@JustaSqu1d JustaSqu1d requested a review from a team as a code owner February 9, 2023 02:08
@JustaSqu1d
Copy link
Member Author

I don't have Experiments. Could someone test this?

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #1912 (ee826c2) into master (546f051) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
+ Coverage   33.32%   33.33%   +0.01%     
==========================================
  Files          97       97              
  Lines       18750    18753       +3     
==========================================
+ Hits         6249     6252       +3     
  Misses      12501    12501              
Flag Coverage Δ
macos-latest-3.10 33.32% <100.00%> (+0.01%) ⬆️
macos-latest-3.11 33.32% <100.00%> (+0.01%) ⬆️
macos-latest-3.8 33.33% <100.00%> (+0.01%) ⬆️
macos-latest-3.9 33.33% <100.00%> (+0.01%) ⬆️
ubuntu-latest-3.10 33.32% <100.00%> (+0.01%) ⬆️
ubuntu-latest-3.11 33.32% <100.00%> (+0.01%) ⬆️
ubuntu-latest-3.8 33.33% <100.00%> (+0.01%) ⬆️
ubuntu-latest-3.9 33.33% <100.00%> (+0.01%) ⬆️
windows-latest-3.10 33.32% <100.00%> (+0.01%) ⬆️
windows-latest-3.11 33.32% <100.00%> (+0.01%) ⬆️
windows-latest-3.8 33.33% <100.00%> (+0.01%) ⬆️
windows-latest-3.9 33.33% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/flags.py 76.09% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 546f051...ee826c2. Read the comment docs.

@Lulalaby
Copy link
Member

Lulalaby commented Feb 9, 2023

I don't have Experiments. Could someone test this?

This is rolled out to all users on all versions (Update if possible, I won't search all version numbers rn)

@JustaSqu1d
Copy link
Member Author

I don't have Experiments. Could someone test this?

This is rolled out to all users on all versions (Update if possible, I won't search all version numbers rn)

Tested. It works.

Lulalaby
Lulalaby previously approved these changes Feb 9, 2023
@Lulalaby Lulalaby requested a review from ChickenDevs February 9, 2023 02:25
@Lulalaby Lulalaby enabled auto-merge (squash) February 9, 2023 02:26
auto-merge was automatically disabled February 9, 2023 02:28

Head branch was pushed to by a user without write access

@JustaSqu1d JustaSqu1d added status: awaiting review Awaiting review from a maintainer feature Implements a feature python labels Feb 9, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) February 9, 2023 02:29
@Lulalaby Lulalaby merged commit e18d571 into Pycord-Development:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Implements a feature status: awaiting review Awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants