docs: New select examples #1843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create channel_select.py Adds an example for the new channel selects * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Create role_select.py Adds an example of the new role selects * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update role_select.py Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Middledot
previously approved these changes
Jan 5, 2023
BobDotCom
requested changes
Jan 5, 2023
Contributor
BobDotCom
left a comment
BobDotCom
left a comment
There was a problem hiding this comment.
No need to redefine __init__ with just a super call, leaving it unset will cause it to inherit __init__ from the superclass anyways.
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
for more information, see https://pre-commit.ci
Member
Author
|
@Nzii3 look at comments |
BobDotCom
approved these changes
Jan 5, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1843 +/- ##
==========================================
+ Coverage 33.17% 33.18% +0.01%
==========================================
Files 96 96
Lines 18672 18672
==========================================
+ Hits 6194 6197 +3
+ Misses 12478 12475 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
plun1331
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.