Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: New select examples #1843

Merged
merged 7 commits into from
Jan 5, 2023
Merged

docs: New select examples #1843

merged 7 commits into from
Jan 5, 2023

Conversation

Lulalaby
Copy link
Member

No description provided.

Nzii3 and others added 2 commits December 27, 2022 19:13
* Create channel_select.py

Adds an example for the new channel selects

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Create role_select.py

Adds an example of the new role selects

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update role_select.py

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@Lulalaby Lulalaby requested a review from a team as a code owner December 27, 2022 18:13
@Lulalaby Lulalaby added the examples Pycord examples label Dec 27, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) December 27, 2022 18:14
Middledot
Middledot previously approved these changes Jan 5, 2023
Copy link
Member

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to redefine __init__ with just a super call, leaving it unset will cause it to inherit __init__ from the superclass anyways.

examples/views/channel_select.py Outdated Show resolved Hide resolved
examples/views/role_select.py Outdated Show resolved Hide resolved
Lulalaby and others added 2 commits January 5, 2023 18:25
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
@Lulalaby
Copy link
Member Author

Lulalaby commented Jan 5, 2023

@Nzii3 look at comments

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #1843 (0cfbd8d) into master (0c1e611) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1843      +/-   ##
==========================================
+ Coverage   33.17%   33.18%   +0.01%     
==========================================
  Files          96       96              
  Lines       18672    18672              
==========================================
+ Hits         6194     6197       +3     
+ Misses      12478    12475       -3     
Flag Coverage Δ
macos-latest-3.10 33.17% <ø> (?)
macos-latest-3.11 33.17% <ø> (?)
macos-latest-3.8 33.18% <ø> (?)
macos-latest-3.9 33.18% <ø> (?)
ubuntu-latest-3.10 33.17% <ø> (ø)
ubuntu-latest-3.11 33.17% <ø> (?)
ubuntu-latest-3.8 33.18% <ø> (ø)
ubuntu-latest-3.9 33.18% <ø> (ø)
windows-latest-3.10 33.17% <ø> (?)
windows-latest-3.11 33.17% <ø> (?)
windows-latest-3.8 33.18% <ø> (?)
windows-latest-3.9 33.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/player.py 25.32% <0.00%> (+0.32%) ⬆️
discord/sinks/core.py 40.42% <0.00%> (+1.06%) ⬆️
discord/_typed_dict.py 100.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1e611...0cfbd8d. Read the comment docs.

@Lulalaby Lulalaby disabled auto-merge January 5, 2023 17:42
@BobDotCom BobDotCom enabled auto-merge (squash) January 5, 2023 17:43
@BobDotCom BobDotCom merged commit b00b3da into master Jan 5, 2023
@Lulalaby Lulalaby deleted the new-select-examples branch January 5, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Pycord examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants