Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use correct aiohttp extra in requirements/speed.txt #1830

Merged
merged 1 commit into from
Dec 19, 2022
Merged

chore: use correct aiohttp extra in requirements/speed.txt #1830

merged 1 commit into from
Dec 19, 2022

Conversation

classabbyamp
Copy link
Contributor

Summary

aiohttp does not have an extra called "speed", but does have one called "speedups"

https://github.com/aio-libs/aiohttp/blob/v3.8.3/setup.cfg#L67-L71

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@classabbyamp classabbyamp requested a review from a team as a code owner December 17, 2022 00:07
@classabbyamp
chore: use correct aiohttp extra in requirements/speed.txt
0428238 
aiohttp does not have an extra called "speed", but does have one called "speedups"

https://github.com/aio-libs/aiohttp/blob/v3.8.3/setup.cfg#L67-L71
@classabbyamp classabbyamp changed the title requirements/speed.txt: use correct aiohttp extra chore: use correct aiohttp extra in requirements/speed.txt Dec 17, 2022
classabbyamp added a commit to 0x5c/minibot that referenced this pull request Dec 19, 2022
@classabbyamp
migrate to py-cord
b31da43 
- aiohttp in requirements.txt can be removed when Pycord-Development/pycord#1830 is merged
- added logging to see errors from py-cord
@classabbyamp classabbyamp mentioned this pull request Dec 19, 2022
Merged
@Dorukyum Dorukyum enabled auto-merge (squash) December 19, 2022 11:22
@Dorukyum Dorukyum merged commit aaeff37 into Pycord-Development:master Dec 19, 2022
@classabbyamp classabbyamp deleted the patch-1 branch December 19, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@classabbyamp @Lulalaby @Dorukyum