Skip to content

Implement resume_gateway_url #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2022
Merged

Implement resume_gateway_url #1559

merged 2 commits into from
Aug 11, 2022

Conversation

@Dorukyum
Copy link
Member

Summary

Implements discord/discord-api-docs#5282 & discord/discord-api-docs#5301

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Lulalaby Lulalaby self-assigned this Aug 10, 2022
@Lulalaby Lulalaby added priority: high High Priority status: in progress Work in Progess feature Implements a feature Merge with squash upcoming discord feature Involves a feature not yet fully released by Discord labels Aug 10, 2022
@Lulalaby Lulalaby added this to the v2.1 milestone Aug 10, 2022
@Dorukyum Dorukyum added status: awaiting review Awaiting review from a maintainer priority: high High Priority feature Implements a feature and removed priority: high High Priority status: in progress Work in Progess feature Implements a feature labels Aug 10, 2022
plun1331
plun1331 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me thinks is ok

VincentRPS
VincentRPS approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@VincentRPS VincentRPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Middledot
Middledot previously approved these changes Aug 11, 2022
View reviewed changes
BobDotCom
BobDotCom approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BobDotCom BobDotCom marked this pull request as ready for review August 11, 2022 15:56
@BobDotCom BobDotCom dismissed Middledot’s stale review August 11, 2022 15:57

Enabling auto-merge

@BobDotCom BobDotCom enabled auto-merge August 11, 2022 15:57
@BobDotCom BobDotCom merged commit 7418cd4 into Pycord-Development:master Aug 11, 2022
@Dorukyum Dorukyum deleted the resume_gateway_url branch January 25, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plun1331 plun1331 plun1331 approved these changes

@BobDotCom BobDotCom BobDotCom approved these changes

@VincentRPS VincentRPS VincentRPS approved these changes

@Middledot Middledot Middledot left review comments

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

Assignees

@Lulalaby Lulalaby

@Dorukyum Dorukyum

Labels

feature Implements a feature priority: high High Priority status: awaiting review Awaiting review from a maintainer upcoming discord feature Involves a feature not yet fully released by Discord

Projects

Pycord Releases
Status: Done

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

6 participants

@Dorukyum @plun1331 @BobDotCom @Middledot @VincentRPS @Lulalaby