Skip to content

feat(bot.py): fix type issues #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 3, 2022
Merged

feat(bot.py): fix type issues #1534

merged 9 commits into from
Sep 3, 2022

Conversation

@EmmmaTech
Copy link
Contributor

Summary

This PR fixes the (many) type issues in bot.py and a few type issues in commands/core.py.
This PR also makes the code more efficient and readable with issues that aren't entirely type related.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Lulalaby Lulalaby added bug Something isn't working feature Implements a feature priority: medium Medium Priority status: in progress Work in Progess labels Jul 30, 2022
@Lulalaby Lulalaby added this to the v2.1 milestone Jul 30, 2022
searchify7
searchify7 previously approved these changes Jul 31, 2022
View reviewed changes
BobDotCom
BobDotCom previously requested changes Aug 12, 2022
View reviewed changes
@BobDotCom
Copy link
Contributor

Please resolve merge conflicts

@BobDotCom
Copy link
Contributor

Is this finished?

@EmmmaTech
Copy link
Contributor Author

Is this finished?

Nope, hence why it's still marked as a draft

@EmmmaTech EmmmaTech marked this pull request as ready for review August 25, 2022 01:51
@EmmmaTech
Copy link
Contributor Author

This is now ready for review.

@Lulalaby Lulalaby enabled auto-merge (squash) August 25, 2022 02:32
Lulalaby
Lulalaby approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@Lulalaby Lulalaby requested a review from BobDotCom August 25, 2022 02:33
@Dorukyum Dorukyum self-requested a review September 3, 2022 09:10
Dorukyum
Dorukyum approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@Lulalaby Lulalaby merged commit 3ff992a into Pycord-Development:master Sep 3, 2022
BobDotCom added a commit that referenced this pull request Sep 6, 2022
@EmmmaTech @BobDotCom @Lulalaby
feat(bot.py): fix type issues (#1534)
e321fa3 
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

+1 more reviewer

@searchify7 searchify7 searchify7 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@EmmmaTech EmmmaTech

Labels

bug Something isn't working feature Implements a feature priority: medium Medium Priority status: in progress Work in Progess

Projects

Pycord Releases
Status: Done

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

5 participants

@EmmmaTech @BobDotCom @Lulalaby @Dorukyum @searchify7