Add transparent color

[veerack]

discord.Color.transparent() -> Method that returns a cls(0x2F3136) (embed bg color)

Summary

Checklist

• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed)
• This PR is not a code change (e.g. documentation, README, ...)

[zeffo]

This is not transparent for light mode users or AMOLED mobile users.

[veerack]

This is not transparent for light mode users or AMOLED mobile users

as i know, for light/amoled themes there's any color that can be considered transparent.. it should be just an utility to have a "transparent" color ready to use, instead need to search for it. (another consideration: there's still people that seriously use light mode?)

[marzeq]

This is not transparent for light mode users or AMOLED mobile users

as i know, for light/amoled themes there's any color that can be considered transparent.. it should be just an utility to have a "transparent" color ready to use, instead need to search for it. (another consideration: there's still people that seriously use light mode?)

You shouldn't leave out a minority. This also could be misleading that it's actually a transparent colour.

[cbrxyz]

Yes, I agree. I think adding this method is fine, but it just can't be called transparent because it's not transparent. It may give a transparent effect on some dark theme interfaces, but it is not transparent.

[BobDotCom]

I think if this was changed to have a parameter theme of type Literal("dark", "light", "amoled") and defaulted to "dark", each theme corresponding to its inherent theme, it would work. I would also suggest that classmethods be added for light and amoled, and this method accessed those.

[cbrxyz]

I think if this was changed to have a parameter theme of type Literal("dark", "light", "amoled") and defaulted to "dark", each theme corresponding to its inherent theme, it would work. I would also suggest that classmethods be added for light and amoled, and this method accessed those.

I personally don't like this either, because again, this isn't transparent. That's just a misleading method name. I understand where you're coming from, but "blending into one user's background" does not make something transparent.

Also, if Discord ever does create a transparent option for certain UI, then it will be helpful to not have this method implemented. However, I do like the idea of adding three explicit methods to match the dark/light/AMOLED colors.

[BobDotCom]

I personally don't like this either, because again, this isn't transparent. That's just a misleading method name. I understand where you're coming from, but "blending into one user's background" does not make something transparent.

Also, if Discord ever does create a transparent option for certain UI, then it will be helpful to not have this method implemented. However, I do like the idea of adding three explicit methods to match the dark/light/AMOLED colors.

Maybe rename transparent to theme? either that or remove this method completely

[cbrxyz]

I personally don't like this either, because again, this isn't transparent. That's just a misleading method name. I understand where you're coming from, but "blending into one user's background" does not make something transparent.
Also, if Discord ever does create a transparent option for certain UI, then it will be helpful to not have this method implemented. However, I do like the idea of adding three explicit methods to match the dark/light/AMOLED colors.

Maybe rename transparent to theme? either that or remove this method completely

I would just suggest not adding this method. Even if you specified the theme, it will need a parameter, which I see you suggest as using Literal("dark", "light", "amoled"), but I don't think that aligns well with discord.py-esque syntax (I think a method like that should use an enum instead of a Literal of strings, like other methods where a parameter is a set of defined values).

But why even add another enum? I would just suggest making three new methods, something like dark_theme_sidebar (since dark_theme is already implemented), amoled_theme, and light_theme. No enum needed, and it's like all of the other colors.

[itznao]

This is useless due to bots not being able to know which theme a user is using, this means that if someone choses 'light_transparent' for example, it wont show on dark theme vice versa.

[veerack]

i unluckily don't have amoled theme, if someone else have it, feel free to add cls for transparent embed for amoled by himself

[veerack]

fixed typo in constructor and changed classmethod name to embed_background with theme argument defaulted to "dark" (missing amoled)

[izxxr]

i unluckily don't have amoled theme, if someone else have it, feel free to add cls for transparent embed for amoled by himself

It's just pure black.

[BobDotCom]

See suggested changes

[Lulalaby]

oh

[Dorukyum]

Could you document the theme parameter?

Resolved