Add missing **kwargs param to support non-explicit parameters in SlashCommandGroup (fixes issue introduced by #1127)
#1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shCommandGroup` (fixes issue introduced by #1127)
krittick
added
bug
|
Yeah, and this PR didn't fix it properly because I missed that too. I reverted this already. |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1127 fixed an issue by allowing keyword arguments to be accepted, but it also inadvertently removed the **kwargs parameter that is still needed for other variables in the class (e.g.
check).Specifically, this error is fixed by this PR:
TypeError: SlashCommandGroup.__init__() got an unexpected keyword argument 'checks'Checklist
type: ignorecomments were used, a comment is also left explaining why