fix: 🐛 TypeError when specifying thread_name in Webhook.send (#2761)

* 🐛 Handle `thread_name` in `handle_message_parameters` to allow sending to thread with multipart

* 📝 CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>

---------

Signed-off-by: Paillat <me@paillat.dev>
Signed-off-by: Paillat <jeremiecotti@ik.me>
Co-authored-by: plun1331 <plun1331@gmail.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>

Author: 3 people

CHANGELOG.md

@@ -106,7 +106,9 @@ These changes are available on the `master` branch, but have not yet been releas
 - Fixed `ForumChannel.edit` allowing `default_reaction_emoji` to be `None`.
   ([#2739](https://github.com/Pycord-Development/pycord/pull/2739))
 - Fixed missing `None` type hints in `Select.__init__`.
-  ([#2746](https://github.com/Pycord-Development/pycord/pull/2746))
+  ([#2746])(https://github.com/Pycord-Development/pycord/pull/2746)
+- Fixed `TypeError` when specifying `thread_name` in `Webhook.send`.
+  ([#2761])(https://github.com/Pycord-Development/pycord/pull/2761)
 - Updated `valid_locales` to support `in` and `es-419`.
   ([#2767](https://github.com/Pycord-Development/pycord/pull/2767))
 - Fixed `Webhook.edit` not working with `attachments=[]`.

discord/webhook/async_.py

@@ -337,16 +337,12 @@ def execute_webhook(
         multipart: list[dict[str, Any]] | None = None,
         files: list[File] | None = None,
         thread_id: int | None = None,
-        thread_name: str | None = None,
         wait: bool = False,
     ) -> Response[MessagePayload | None]:
         params = {"wait": int(wait)}
         if thread_id:
             params["thread_id"] = thread_id
 
-        if thread_name:
-            payload["thread_name"] = thread_name
-
         route = Route(
             "POST",
             "/webhooks/{webhook_id}/{webhook_token}",
@@ -633,6 +629,7 @@ def handle_message_parameters(
     allowed_mentions: AllowedMentions | None = MISSING,
     previous_allowed_mentions: AllowedMentions | None = None,
     suppress: bool = False,
+    thread_name: str | None = None,
 ) -> ExecuteWebhookParameters:
     if files is not MISSING and file is not MISSING:
         raise TypeError("Cannot mix file and files keyword arguments.")
@@ -717,6 +714,9 @@ def handle_message_parameters(
 
     payload["flags"] = flags.value
 
+    if thread_name:
+        payload["thread_name"] = thread_name
+
     if multipart_files:
         multipart.append({"name": "payload_json", "value": utils._to_json(payload)})
         payload = None
@@ -1808,6 +1808,7 @@ async def send(
             applied_tags=applied_tags,
             allowed_mentions=allowed_mentions,
             previous_allowed_mentions=previous_mentions,
+            thread_name=thread_name,
         )
         adapter = async_context.get()
         thread_id: int | None = None
@@ -1824,7 +1825,6 @@ async def send(
             multipart=params.multipart,
             files=params.files,
             thread_id=thread_id,
-            thread_name=thread_name,
             wait=wait,
         )
 

discord/webhook/sync.py

@@ -307,16 +307,12 @@ def execute_webhook(
         multipart: list[dict[str, Any]] | None = None,
         files: list[File] | None = None,
         thread_id: int | None = None,
-        thread_name: str | None = None,
         wait: bool = False,
     ):
         params = {"wait": int(wait)}
         if thread_id:
             params["thread_id"] = thread_id
 
-        if thread_name:
-            payload["thread_name"] = thread_name
-
         route = Route(
             "POST",
             "/webhooks/{webhook_id}/{webhook_token}",
@@ -1080,6 +1076,7 @@ def send(
             allowed_mentions=allowed_mentions,
             previous_allowed_mentions=previous_mentions,
             suppress=suppress,
+            thread_name=thread_name,
         )
         adapter: WebhookAdapter = _get_webhook_adapter()
         thread_id: int | None = None
@@ -1094,7 +1091,6 @@ def send(
             multipart=params.multipart,
             files=params.files,
             thread_id=thread_id,
-            thread_name=thread_name,
             wait=wait,
         )
         if wait: