DEP: Remove docutils upper-pin, bump sphinx
#739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps the version of Sphinx to 7 by relaxing the requirement on the version of docutils. This allows building the docs with a higher version of Sphinx on RTD and locally.
Collaborator
Author
|
Logs from Read the Docs dashboard: https://beta.readthedocs.org/projects/pywavelets/builds/24244868/ The build passes here as well, no warnings emitted. |
rgommers
approved these changes
May 1, 2024
Member
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
LGTM, thanks @agriyakhetarpal!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up from #737 to bump some documentation-related dependencies in
util/readthedocs/requirements.txt, as requested in #737 (review).Changes made
sphinx – set to>=7`docutils– it was the one that was blocking this change.Additional context
I checked many of the pages personally and there seem to be no problems with the build. The documentation does not display any warnings and the build with
-Wpasses locally. All of our extensions and other listed dependencies support Sphinx v7 as well.