Skip to content

Properly check if download() is needed in get_corpus_path() #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 27, 2020
Merged

Conversation

bact
Copy link
Member

@bact bact commented May 26, 2020

Also:

This will partly close #411

@bact bact added the refactoring a technical improvement which does not add any new features or change existing features. label May 26, 2020
@bact bact added this to the 2.2 milestone May 26, 2020
@bact bact self-assigned this May 26, 2020
@pep8speaks
Copy link

pep8speaks commented May 26, 2020

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-27 15:24:34 UTC

@coveralls
Copy link

coveralls commented May 26, 2020

Coverage Status

Coverage remained the same at 92.319% when pulling f2a343d on more-test-cases into 4c22970 on dev.

@bact bact changed the title More test cases for royin romaization Properly check if download() is needed in get_corpus_path() May 26, 2020
@bact bact merged commit 4a86bca into dev May 27, 2020
@bact bact deleted the more-test-cases branch May 27, 2020 21:17
@bact bact mentioned this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring a technical improvement which does not add any new features or change existing features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Considerations for language model inclusion in default package or download them later Improving test coverage and polishing existing functions
3 participants