Skip to content

Commit dd2df94

Browse files
authored
Merge pull request #494 from bact/add-github-templates
Add issue/PR templates
2 parents 4285309 + 8d13f73 commit dd2df94

File tree

5 files changed

+86
-31
lines changed

5 files changed

+86
-31
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 0 additions & 30 deletions
This file was deleted.
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature request
3+
about: Propose a change or an addition
4+
---
5+
6+
## Detailed description
7+
<!--- Provide a detailed description of the change or addition you are proposing -->
8+
9+
## Context
10+
<!--- Why is this change important to you? How would you use it? -->
11+
<!--- How can it benefit other users? -->
12+
13+
## Possible implementation
14+
<!--- Not obligatory, but suggest an idea for implementing addition or change -->
15+
16+
**Your environment**
17+
* PyThaiNLP version:
18+
* Python version:
19+
* Operating system and version (distro, 32/64-bit):
20+
* More info (Docker, VM, etc.):
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
---
2+
name: Issue report
3+
about: Create a report to help us improve
4+
---
5+
6+
<!--- Provide a general summary of the issue in the Title above -->
7+
8+
## Description
9+
<!--- Provide a more detailed introduction to the issue itself. -->
10+
<!-- Why you consider it to be an issue or a bug. -->
11+
12+
**Expected results**
13+
<!-- Tell us what should happen. -->
14+
15+
**Current results**
16+
<!-- Tell us what happens instead. -->
17+
<!-- You can also put screenshot here. -->
18+
19+
**Possible solution**
20+
<!-- (Optional) Suggest a fix for the issue,
21+
or ideas how to implement the change. -->
22+
23+
**Steps to reproduce**
24+
<!-- Steps to reproduce the behavior. -->
25+
1.
26+
2.
27+
3.
28+
29+
<!-- You can also put a source code here. -->
30+
```python
31+
```
32+
33+
## Context
34+
<!-- How has this issue affected you? -->
35+
<!-- What are you trying to accomplish? -->
36+
<!-- Providing context helps us come up with a solution that is most useful in the real world. -->
37+
38+
**Your environment**
39+
* PyThaiNLP version:
40+
* Python version:
41+
* Operating system and version (distro, 32/64-bit):
42+
* More info (Docker, VM, etc.):
43+
44+
**Files**
45+
<!-- (Optional) A list of relevant files for this issue. -->
46+
<!-- This will help people navigate the project and offer some clues of where to start. -->
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
### What does this changes
2+
3+
Brief summary of the changes
4+
5+
### What was wrong
6+
7+
Description of what was the root cause of the issue.
8+
9+
### How this fixes it
10+
11+
Description of how the changes fix the issue.
12+
13+
Fixes #...
14+
15+
### Your checklist for this pull request
16+
🚨Please review the [guidelines for contributing](../CONTRIBUTING.md) to this repository.
17+
18+
- [ ] Passed code styles and structures
19+
- [ ] Passed code linting checks and unit test

.github/workflows/pythainlp-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
python-version: ${{ matrix.python-version }}
2222
- name: Install dependencies
2323
run: |
24-
python -m pip install --upgrade pip pytest wheel flake8
24+
python -m pip install --upgrade pip pytest wheel flake8 flake8-commas flake8-comprehensions
2525
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
2626
pip install "h5py>=2.10.0,<3" "tensorflow>=2.3.1,<3"
2727
pip install torch==1.7.0+cpu -f https://download.pytorch.org/whl/torch_stable.html

0 commit comments

Comments
 (0)