Added Dockerfile #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wannaphong
reviewed
Oct 9, 2022
|
|
||
| RUN pip install --no-cache datasets transformers soundfile numpy torch torchaudio | ||
|
|
||
| COPY . . |
There was a problem hiding this comment.
Can you add RUN pip install -e . after this line?
There was a problem hiding this comment.
Oh yeah. Sure thing. I also removed the README from the .dockerignore as it is embedded in the setup.
There was a problem hiding this comment.
Oh yeah. Sure thing. I also removed the README from the .dockerignore as it is embedded in the setup.
It is before COPY . .. I think it should run RUN pip install -e . after COPY . ..
There was a problem hiding this comment.
Oh I'm so sorry. Must be getting dizzy 🥴. I just tried it in the already existing test container on my machine and forgot that the relevant files sure need to be copied.😵💫 Should be fixed now.
wannaphong
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dockerfile (and .dockerignore).
Added a Docker section to the README.
This is related to issue #8.