Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfaults caused by modifying existing shared library #295

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Fix segfaults caused by modifying existing shared library #295

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0ab8ee
Fix segfaults caused by modifying existing shared library
erikjohnston Sep 29, 2022
2bb9ba7
Use os.rename
erikjohnston Sep 29, 2022
78b615f
Use os.replace
erikjohnston Sep 29, 2022
5c0222b
Update setuptools_rust/build.py
erikjohnston Sep 29, 2022
6fd4205
Update changelog
erikjohnston Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion setuptools_rust/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,18 @@ def install_extension(
os.makedirs(os.path.dirname(ext_path), exist_ok=True)

log.info("Copying rust artifact from %s to %s", dylib_path, ext_path)
shutil.copyfile(dylib_path, ext_path)

# We want to atomically replace any existing library file. We can't
# just copy the new library directly on top of the old one as that
# causes the existing library to be modified (rather the replaced).
# This means that any process that currently uses the shared library
# will see it modified and likely segfault.
#
# We first copy the file to the same directory, as `os.rename`
# doesn't work across file system boundaries.
temp_ext_path = ext_path + "~"
adamreichold marked this conversation as resolved.
Show resolved Hide resolved
shutil.copyfile(dylib_path, temp_ext_path)
os.rename(temp_ext_path, ext_path)
erikjohnston marked this conversation as resolved.
Show resolved Hide resolved

if sys.platform != "win32" and not debug_build:
args = []
Expand Down