Open
Conversation
mattiapenati
force-pushed
the
api-version
branch
2 times, most recently
from
6f02c65 to
c29564a
Compare
mattiapenati
force-pushed
the
api-version
branch
from
c29564a to
30dc6e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the build configuration to select the target Numpy C API version and adjusts struct definitions to match the user selected version.
The default configuration has been chosen to match the setting in the first release of Numpy v2.
The only potentially breaking change is the new definition of
PyUFuncObject. The structPyUFuncObjecthas been updated to match the definition given in Numpy source. The previous definition matched the definition contained in documentation. I think the former is more accurate.I understand that this PR is not small and that not all changes can be easily reviewed, it wasn't easy to put everything together either. If the PR is too large, I could split it into smaller changes. Anyway, I hope it will help improve the FFI.