Added add_note method to PyErr #5489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
add-note
branch
2 times, most recently
from
bd97972 to
c6618ad
Compare
Member
|
See also #5349 (comment) - a long discussion about using whether we would use I see no harm in adding this API for now. cc @Icxolu just in case you have a different opinion? |
Contributor
Author
|
Yes -- it'd be nice if there was a CPython API for this. I added this utility internally to cryptography, and figured it'd be useful for others. |
Contributor
|
I think adding the API is fine. I still wouldn't you use it internally, its to easy to miss the notes in both Rust and Python IMO, but giving downstream users the option for their error sounds good. |
LilyFirefly
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.