split PyFunctionArgument to specialize Option
#5002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds const generic parameter to `PyFunctionArgument` to allow specialization. This allows `Option` wrapped extraction of some types that can't implement `FromPyObject(Bound)` because they require a `holder` to borrow from, most notably `&T` for `T: PyClass`. Closes PyO3#4965
Icxolu
commented
Mar 28, 2025
| } | ||
|
|
||
| impl TypeExt for syn::Type { | ||
| fn elide_lifetimes(mut self) -> Self { |
There was a problem hiding this comment.
I guess we should add a FIXME somewhere here, and say that we want to remove this again.
There was a problem hiding this comment.
I'm happy to leave it as-is, we can see how brittle it is in practice (or maybe we end up removing this again when it's unused).
|
Oops forgot to click merge 🤦 |
Icxolu
added a commit
to Icxolu/pyo3
that referenced
this pull request
Apr 1, 2025
Icxolu
added a commit
to Icxolu/pyo3
that referenced
this pull request
Apr 1, 2025
davidhewitt
pushed a commit
that referenced
this pull request
Apr 4, 2025
davidhewitt
pushed a commit
that referenced
this pull request
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds const generic parameter to
PyFunctionArgumentto allow specialization. This allowsOptionwrapped extraction of some types that can't implementFromPyObject(Bound)because they require aholderto borrow from, most notably&TforT: PyClass.Option, innerOptions will use theFromPyObjectimplToDo:
Closes #4965