codex: advance quality tool adoption

Author: saidctb

.github/workflows/quality.yml

@@ -39,6 +39,11 @@ jobs:
         run: pip-audit . --cache-dir /tmp/pip-audit-cache
       - name: Vulture dead-code scan
         run: vulture
+      - name: Radon complexity policy
+        env:
+          PR_BASE_SHA: ${{ github.event.pull_request.base.sha }}
+          PUSH_BEFORE_SHA: ${{ github.event.before }}
+        run: python tools/check_radon_policy.py --base-ref auto
       - name: Radon complexity report
         continue-on-error: true
         run: radon cc c_parser fortran_parser semantics x2py -n C -s --total-average
@@ -112,31 +117,33 @@ jobs:
       - name: Run tests with a changing random seed
         env:
           PYTHONPATH: .
-        run: python -m pytest -q -n auto --randomly-seed=${{ github.run_id }} --benchmark-disable
+        run: python -m pytest -q -n auto --randomly-seed=${{ github.run_id }}
 
-  benchmark:
-    if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
-    runs-on: ubuntu-latest
-    timeout-minutes: 15
-    permissions:
-      contents: read
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-      - name: Set up Python
-        uses: actions/setup-python@v5
-        with:
-          python-version: "3.12"
-      - name: Install QA dependencies
-        run: |
-          python -m pip install --upgrade pip
-          python -m pip install -e ".[qa]"
-      - name: Run parser benchmarks
-        env:
-          PYTHONPATH: .
-        run: python -m pytest -q tests/benchmarks -m benchmark --benchmark-only --benchmark-json=benchmark.json
-      - name: Upload benchmark report
-        uses: actions/upload-artifact@v4
-        with:
-          name: parser-benchmark-${{ github.run_id }}
-          path: benchmark.json
+  # Benchmark workflow is intentionally parked for later activation.
+  # benchmark:
+  #   if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
+  #   runs-on: ubuntu-latest
+  #   timeout-minutes: 15
+  #   permissions:
+  #     contents: read
+  #   steps:
+  #     - name: Checkout repository
+  #       uses: actions/checkout@v4
+  #     - name: Set up Python
+  #       uses: actions/setup-python@v5
+  #       with:
+  #         python-version: "3.12"
+  #     - name: Install QA dependencies
+  #       run: |
+  #         python -m pip install --upgrade pip
+  #         python -m pip install -e ".[qa]"
+  #     - name: Run parser benchmarks
+  #       env:
+  #         PYTHONPATH: .
+  #       run: python -m pytest -q tests/benchmarks -m benchmark --benchmark-only --benchmark-json=benchmark.json
+  #     - name: Upload benchmark report
+  #       uses: actions/upload-artifact@v4
+  #       with:
+  #         name: parser-benchmark-${{ github.run_id }}
+  #         path: benchmark.json
+  #         retention-days: 90

.github/workflows/tests.yml

@@ -36,7 +36,7 @@ jobs:
           PYTHONPATH: .
           COVERAGE_PROCESS_START: ${{ github.workspace }}/pyproject.toml
           HYPOTHESIS_PROFILE: ci
-        run: python -m coverage run -m pytest -q -n auto --randomly-seed=1 --benchmark-disable
+        run: python -m coverage run -m pytest -q -n auto --randomly-seed=1
       - name: Combine coverage data
         run: python -m coverage combine
       - name: Report coverage

.pre-commit-config.yaml

@@ -29,6 +29,13 @@ repos:
         pass_filenames: false
         files: \.py$
 
+      - id: radon-policy
+        name: radon complexity policy
+        entry: python3 tools/check_radon_policy.py
+        language: system
+        pass_filenames: false
+        files: \.py$
+
       - id: vulture
         name: vulture dead-code scan
         entry: vulture

c_parser/__init__.py

@@ -59,9 +59,9 @@
     "CChar",
     "CComposedType",
     "CConst",
+    "CDiagnostic",
     "CDouble",
     "CDoubleComplex",
-    "CDiagnostic",
     "CEnum",
     "CEnumerator",
     "CFile",
@@ -80,8 +80,8 @@
     "CMacroDependency",
     "CParameter",
     "CParseError",
-    "CPointer",
     "CParser",
+    "CPointer",
     "CProject",
     "CQualifier",
     "CRawDirective",

c_parser/lexer.py

@@ -786,13 +786,13 @@ def lex_c_source(source: str, filename: str | None = None) -> list[CToken]:
 
 
 __all__ = (
-    "CLogicalRecord",
     "CLineMapping",
+    "CLogicalRecord",
     "CToken",
     "CTopLevelSegment",
     "NormalizedCSource",
-    "line_mappings_for_source",
     "lex_c_source",
+    "line_mappings_for_source",
     "normalize_c_source",
     "split_top_level_c_source",
     "strip_c_comments",

c_parser/models.py

@@ -52,9 +52,9 @@ def c_model_to_dict(obj: Any, _seen: set[int] | None = None) -> Any:
     if isinstance(obj, CQualifier):
         return obj.spelling
     if isinstance(obj, CType):
-        if isinstance(obj, (CStruct, CUnion, CEnum, CTypedef)) and id(obj) in _seen:
+        if isinstance(obj, CStruct | CUnion | CEnum | CTypedef) and id(obj) in _seen:
             return {"reference": obj.reference_name}
-        if isinstance(obj, (CStruct, CUnion, CEnum, CTypedef)):
+        if isinstance(obj, CStruct | CUnion | CEnum | CTypedef):
             _seen.add(id(obj))
         payload = {"model": type(obj).__name__}
         payload.update(
@@ -87,7 +87,7 @@ def c_model_to_dict(obj: Any, _seen: set[int] | None = None) -> Any:
         return [c_model_to_dict(v, _seen) for v in obj]
     if isinstance(obj, dict):
         return {k: c_model_to_dict(v, _seen) for k, v in obj.items()}
-    if isinstance(obj, (set, frozenset)):
+    if isinstance(obj, set | frozenset):
         return sorted(c_model_to_dict(v, _seen) for v in obj)
     return obj
 
@@ -406,7 +406,7 @@ def type(self) -> CFunctionType:
 @dataclass
 class CStruct(CType):
     name: str | None = None
-    members: list["CVariable"] = field(default_factory=list)
+    members: list[CVariable] = field(default_factory=list)
     anonymous_id: str | None = None
     is_incomplete: bool = False
     source_location: CSourceLocation | None = None
@@ -420,7 +420,7 @@ def reference_name(self) -> str:
 @dataclass
 class CUnion(CType):
     name: str | None = None
-    members: list["CVariable"] = field(default_factory=list)
+    members: list[CVariable] = field(default_factory=list)
     anonymous_id: str | None = None
     is_incomplete: bool = False
     source_location: CSourceLocation | None = None