Skip to content

Commit 77c74fc

Browse files
authored
feat: PR and Issues template (#17)
* feat: PR and Issues template * feat: structured ISSUE templates
1 parent f9523d1 commit 77c74fc

File tree

10 files changed

+167
-3
lines changed

10 files changed

+167
-3
lines changed
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
---
2+
name: Bug Report
3+
about: Create a report to help us improve
4+
title: 'bug: '
5+
labels: 'bug'
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the bug**
11+
A clear and concise description of what the bug is.
12+
13+
**To Reproduce**
14+
Steps to reproduce the behavior:
15+
1. Command-line arguments used: `...`
16+
2. Input data (if applicable): `...`
17+
3. See error
18+
19+
**Expected behavior**
20+
A clear and concise description of what you expected to happen.
21+
22+
**Error messages or logs**
23+
If applicable, add any error messages or logs to help explain your problem.
24+
25+
**Environment (please complete the following information):**
26+
- OS: [e.g. Ubuntu 20.04]
27+
- simstring-rs version: [e.g. 0.1.0]
28+
- Rust version: [e.g. 1.58.1]
29+
30+
**Additional context**
31+
Add any other context about the problem here.

.github/ISSUE_TEMPLATE/chore.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
name: Chore
3+
about: Other tasks
4+
title: 'chore: '
5+
labels: 'chore'
6+
assignees: ''
7+
8+
---
9+
10+
**Description**
11+
A clear and concise description of the task.

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: Ask a question
4+
url: https://github.com/bebr/simstring_rs/discussions/new
5+
about: Please ask and answer questions here.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
---
2+
name: Documentation Improvement
3+
about: Suggest an improvement for the documentation
4+
title: 'docs: '
5+
labels: 'documentation'
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the improvement you'd like**
11+
A clear and concise description of what you want to happen.
12+
13+
**Additional context**
14+
Add any other context or screenshots about the documentation improvement here.
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature Request
3+
about: Suggest an idea for this project
4+
title: 'feat: '
5+
labels: 'enhancement'
6+
assignees: ''
7+
8+
---
9+
10+
**Is your feature request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
**Describe the solution you'd like**
14+
A clear and concise description of what you want to happen.
15+
16+
**Describe alternatives you've considered**
17+
A clear and concise description of any alternative solutions or features you've considered.
18+
19+
**Additional context**
20+
Add any other context or screenshots about the feature request here.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
---
2+
name: Pull Request
3+
about: Propose a change to the project
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
**Description**
11+
12+
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
13+
14+
**Fixes** (issue)
15+
16+
**Type of change**
17+
18+
Please choose the type of change that best describes your PR.
19+
20+
- [ ] `fix(scope)`: A bug fix (non-breaking change which fixes an issue)
21+
- [ ] `feat(scope)`: A new feature (non-breaking change which adds functionality)
22+
- [ ] `feat!(scope)`: A breaking change (fix or feature that would cause existing functionality to not work as expected)
23+
- [ ] `docs(scope)`: This change requires a documentation update
24+
- [ ] `chore(scope)`: Other changes that don't modify src or test files
25+
- [ ] `refactor(scope)`: A code change that neither fixes a bug nor adds a feature
26+
- [ ] `perf(scope)`: A code change that improves performance
27+
- [ ] `test(scope)`: Adding missing tests or correcting existing tests
28+
- [ ] `style(scope)`: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
29+
- [ ] `ci(scope)`: Changes to our CI configuration files and scripts
30+
- [ ] `revert(scope)`: Reverts a previous commit
31+
32+
**How Has This Been Tested?**
33+
34+
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
35+
36+
- [ ] Test A
37+
- [ ] Test B
38+
39+
**Checklist:**
40+
41+
- [ ] My code follows the style guidelines of this project
42+
- [ ] I have performed a self-review of my own code
43+
- [ ] I have commented my code, particularly in hard-to-understand areas
44+
- [ ] I have made corresponding changes to the documentation
45+
- [ ] I have added an entry to the CHANGELOG.md file
46+
- [ ] My changes generate no new warnings
47+
- [ ] I have added tests that prove my fix is effective or that my feature works
48+
- [ ] New and existing unit tests pass locally with my changes
49+
- [ ] Any dependent changes have been merged and published in downstream modules

CHANGELOG.md

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
## v0.1.3
2+
3+
### Features
4+
5+
- PR and Issues template
6+
7+
### Other
8+
9+
- added order indipendence test (#12)
10+
11+
## v0.1.2
12+
13+
### Features
14+
15+
- Initial benchmark suite (#11)
16+
- Release: Initial benchmarks compared to other implementations in other languages (#13)
17+
18+
## v0.1.1
19+
20+
### Other
21+
22+
- WIP: Initial proposed search method for hashdb (#7)
23+
24+
## v0.1.0
25+
26+
### Features
27+
28+
- Initial API structure (#1)
29+
30+
### Bug Fixes
31+
32+
- keywords not exceeding 5 items (#3)
33+
- Added tag trigger to CI workflow (#2)
34+

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "simstring_rust"
3-
version = "0.1.2"
3+
version = "0.1.3"
44
description = "A native Rust implementation of the SimString algorithm"
55
license = "MIT"
66
repository = "https://github.com/PyDataBlog/simstring_rs"

src/extractors/character_ngrams.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ impl FeatureExtractor for CharacterNGrams {
1717

1818
fn pad_string(s: &str, padder: &str, n: usize) -> String {
1919
let pad = padder.repeat(n);
20-
format!("{}{}{}", pad, s, pad)
20+
format!("{pad}{s}{pad}")
2121
}
2222

2323
fn init_char_ngrams(s: &str, n: usize) -> Vec<String> {

0 commit comments

Comments
 (0)