Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed check for include_trailing_comma for the Hanging Indent wrap mode #2192

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

bp72
Copy link
Contributor

@bp72 bp72 commented Oct 22, 2023

Closes #2174

When the wrap mode is Hanging Indent it doesn't make sense to take into consideration the value of include_trailing_comma. If we put the trailing comma it'll lead to a syntax error as described in the issue #2174.

An example of hanging indent wrap mode:

from third_party import \
    lib1, lib2, lib3, \
    lib4, lib5, lib6

Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bp72

@staticdev staticdev merged commit 0118e90 into PyCQA:main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isort generates code with syntax errors with profile=black and multi_line_output=2
2 participants