Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash in sys.version_info check #59

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Fix a crash in sys.version_info check #59

merged 2 commits into from
Jan 14, 2022

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented Jan 14, 2022

This previously caused an AttributeError:

if sys.version_info[:2] == "lol":
    ...

It now emits Y003 Unrecognized sys.version_info check. I found this when working on a pull request to add mypy to github actions.

JelleZijlstra
JelleZijlstra approved these changes Jan 14, 2022
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@JelleZijlstra JelleZijlstra merged commit 3de5a0b into master Jan 14, 2022
@JelleZijlstra JelleZijlstra deleted the crash-fix branch January 14, 2022 22:41
@Akuli Akuli mentioned this pull request Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akuli @JelleZijlstra