Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy CI job #498

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Fix mypy CI job #498

merged 4 commits into from
Aug 20, 2024

Conversation

AlexWaygood
Copy link
Collaborator

The 3.13 job seems to have started failing, not sure why: https://github.com/PyCQA/flake8-pyi/actions/runs/10469760712/job/28993477108?pr=497

This comment has been minimized.

@AlexWaygood
Copy link
Collaborator Author

I guess we could also just use a Python 3.12 installation for both mypy jobs and run with --target-version 3.13; no strong opinion on which is better there

@srittau
Copy link
Collaborator

srittau commented Aug 20, 2024

I like using --target-version. The version mypy runs on shouldn't be important, and using a relatively new, but stable Python version seems to be the safest to me.

@AlexWaygood
Copy link
Collaborator Author

AlexWaygood commented Aug 20, 2024

oh, we need to run the mypy-3.8 job using Python 3.8, or the conditional dependency ast_decompiler isn't installed, which is necessary for typechecking to succeed on Python 3.8

srittau
srittau previously approved these changes Aug 20, 2024

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented Aug 20, 2024

oh, we need to run the mypy-3.8 job using Python 3.8, or the conditional dependency ast_decompiler isn't installed, which is necessary for typechecking to succeed on Python 3.8

Could you add a comment about that to the yml file?

@srittau srittau dismissed their stale review August 20, 2024 11:24

see comments

This comment has been minimized.

@AlexWaygood
Copy link
Collaborator Author

oh, we need to run the mypy-3.8 job using Python 3.8, or the conditional dependency ast_decompiler isn't installed, which is necessary for typechecking to succeed on Python 3.8

Could you add a comment about that to the yml file?

done!

@AlexWaygood AlexWaygood requested a review from srittau August 20, 2024 11:26
Copy link

This change has no effect on typeshed. 🤖🎉

@AlexWaygood AlexWaygood changed the title run mypy on job on 3.8 & 3.12 for now Fix mypy CI job Aug 20, 2024
@srittau srittau merged commit 72a2de5 into main Aug 20, 2024
24 checks passed
@srittau srittau deleted the AlexWaygood-patch-1 branch August 20, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants