Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce PEP-570 syntax in stubs #461

Merged
merged 6 commits into from
Mar 10, 2024
Merged

Enforce PEP-570 syntax in stubs #461

merged 6 commits into from
Mar 10, 2024

Conversation

AlexWaygood
Copy link
Collaborator

Closes #173

This comment has been minimized.

@AlexWaygood
Copy link
Collaborator Author

Let's leave this until the next release, since it's hard to fix these with #455 still being an issue in the latest release, and I'm not wild about merging this with such a huge typeshed_primer diff :)

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a few optional comments below.

pyi.py Outdated Show resolved Hide resolved
tests/exit_methods.pyi Outdated Show resolved Hide resolved
tests/exit_methods.pyi Outdated Show resolved Hide resolved

This comment has been minimized.

@srittau srittau closed this Feb 26, 2024
@srittau srittau reopened this Feb 26, 2024

This comment has been minimized.

@AlexWaygood
Copy link
Collaborator Author

Still blocked on python/typeshed#11250, which is still blocked on python/mypy#16843 (mypy 1.9 will contain python/mypy#16750)

@AlexWaygood AlexWaygood closed this Mar 9, 2024
@AlexWaygood AlexWaygood reopened this Mar 9, 2024

This comment has been minimized.

@AlexWaygood AlexWaygood reopened this Mar 10, 2024
Copy link

This change has no effect on typeshed. 🤖🎉

@AlexWaygood AlexWaygood merged commit a044940 into main Mar 10, 2024
78 checks passed
@AlexWaygood AlexWaygood deleted the 570 branch March 10, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce PEP 570-style positional only syntax
2 participants