-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jsonpickle deserialization blacklist #707
Conversation
add jsonpickle deserialization blacklist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition, but this triggered me to look a bit further ahead. What's the requirement/flow for other 3rd party libraries to be added to this static blacklist? |
It's a question about the purpose of bandit. If bandit is desired to find more vulnerability, this check rule should be added. |
I don't know, but I'm pretty sure 3rd party libraries are already covered (I think we have checks for PyYAML). I think what's already covered is based upon what folks using it have needed thus far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add jsonpickle to a file in the examples, possibly pickle_deserialize.py or a new file. Then update test_functional.py to run bandit on that example to ensure the black listed call is correctly detected. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add jsonpickle deserialization blacklist