Pytorch Load / Save Plugin #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin checks for the use of `torch.load` and `torch.save`. Using `torch.load` with untrusted data can lead to arbitrary code execution, and improper use of `torch.save` might expose sensitive data or lead to data corruption. Signed-off-by: Luke Hinds <luke@stacklok.com>
|
Bit of cleaning up to do, will get onto next week |
|
Closing and reopening to trigger precommit ci to auto fix this for you |
for more information, see https://pre-commit.ci
sigmavirus24
reviewed
Mar 3, 2024
ericwb
reviewed
Mar 3, 2024
Signed-off-by: Luke Hinds <luke@stacklok.com>
Signed-off-by: Luke Hinds <luke@stacklok.com>
Signed-off-by: Luke Hinds <luke@stacklok.com>
|
@sigmavirus24 / @ericwb I think I have reviewed most of the points now, fancy taking a second sweep? |
ericwb
reviewed
Mar 13, 2024
Signed-off-by: Luke Hinds <luke@stacklok.com>
for more information, see https://pre-commit.ci
ericwb
reviewed
Aug 24, 2024
sigmavirus24
approved these changes
Aug 24, 2024
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
ericwb
requested changes
Aug 26, 2024
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
|
sorry for late action, changes accepted @ericwb |
ericwb
approved these changes
Sep 23, 2024
ericwb
added a commit
to ericwb/bandit
that referenced
this pull request
Sep 27, 2024
* Pytorch Load / Save Plugin This plugin checks for the use of `torch.load` and `torch.save`. Using `torch.load` with untrusted data can lead to arbitrary code execution, and improper use of `torch.save` might expose sensitive data or lead to data corruption. Signed-off-by: Luke Hinds <luke@stacklok.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add missing save check Signed-off-by: Luke Hinds <luke@stacklok.com> * Review fixes from 8b92a02 Signed-off-by: Luke Hinds <luke@stacklok.com> * Fix tox issues Signed-off-by: Luke Hinds <luke@stacklok.com> * Review fixes Signed-off-by: Luke Hinds <luke@stacklok.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update test_functional.py * Update bandit/plugins/pytorch_load_save.py Co-authored-by: Eric Brown <ericwb@users.noreply.github.com> * Update bandit/plugins/pytorch_load_save.py Co-authored-by: Eric Brown <ericwb@users.noreply.github.com> * Update doc/source/plugins/b704_pytorch_load_save.rst Co-authored-by: Eric Brown <ericwb@users.noreply.github.com> * Update bandit/plugins/pytorch_load_save.py Co-authored-by: Eric Brown <ericwb@users.noreply.github.com> --------- Signed-off-by: Luke Hinds <luke@stacklok.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric Brown <ericwb@users.noreply.github.com> Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin checks for the use of
torch.loadandtorch.save.Using
torch.loadwith untrusted data can lead to arbitrary code execution,and improper use of
torch.savemight expose sensitive data or lead to datacorruption.