Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CMAKE build #70

Merged
merged 4 commits into from
Apr 23, 2014
Merged

fix CMAKE build #70

merged 4 commits into from
Apr 23, 2014

Conversation

cpubug
Copy link
Contributor

@cpubug cpubug commented Apr 23, 2014

No description provided.

@orignal
Copy link
Contributor

orignal commented Apr 23, 2014

You are not supposed to make this change

if (m_LeaseSetUpdated)

  •   {  
    
  •       leaseSet = m_LocalDestination->GetLeaseSet ();
    
  •       m_LeaseSetUpdated = false;
    
  •   }  
    
  •   leaseSet = m_LocalDestination->GetLeaseSet ();
    
  •   if (!leaseSet)
    
  •       return false;
    

Because local LeaseSet will be sent with every single packet, that's produces unnecessary overhead. Should be sent after update only. Null pointer is valid values for leaseSet variable.

orignal added a commit that referenced this pull request Apr 23, 2014
@orignal orignal merged commit d071242 into PurpleI2P:master Apr 23, 2014
@orignal
Copy link
Contributor

orignal commented Apr 23, 2014

Where exactly?
It must be something else.
Basically SendQuickAck is called many times even for HTTP session.

@cpubug
Copy link
Contributor Author

cpubug commented Apr 23, 2014

My mistake. Sorry.

@orignal
Copy link
Contributor

orignal commented Apr 23, 2014

I have found the problem. It was result of my previous commit regarding lambda expression. Will be fixed shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants