Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAM] Wrong response to session create request with invalid key #1257

Closed
Nyanraltotlapun opened this issue Oct 11, 2018 · 1 comment
Closed
Labels

Comments

@Nyanraltotlapun
Copy link

i2pd version: 2.21.0

                                  Issue 1

Request:

"SESSION CREATE STYLE=STREAM ID=test DESTINATION=abracadabra"

Response:

"SESSION STATUS RESULT=DUPLICATED_DEST"

Expected:

"SESSION STATUS RESULT=INVALID_KEY"

                                    Issue 2

Request:

"SESSION CREATE STYLE=STREAM ID=test DESTINATION="

Response:

"SESSION STATUS RESULT=OK DESTINATION=privkey"

Expected:

"SESSION STATUS RESULT=INVALID_KEY"

I believe there should be and error. Because spec define DESTINATION as non optional, and java realization also returns "INVALID_KEY".

@Nyanraltotlapun Nyanraltotlapun changed the title [SAM] wrong response to session create request with invalid key [SAM] Wrong response to session create request with invalid key Oct 11, 2018
@orignal
Copy link
Contributor

orignal commented Oct 11, 2018

I agree, it should be too different reasons

@r4sas r4sas added the SAM label Nov 12, 2018
matthias-hoste pushed a commit to matthias-hoste/i2pd that referenced this issue Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants