Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ProtonMail/go-crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.0
Choose a base ref
...
head repository: ProtonMail/go-crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.3.0
Choose a head ref
  • 9 commits
  • 14 files changed
  • 2 contributors

Commits on May 20, 2025

  1. feat(v2): Tolerate invalid key signatures if one passes

    @lubux
    lubux committed May 20, 2025
    Configuration menu
    Copy the full SHA
    8fe0e95 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #284 from ProtonMail/feat/less-restrictive-key-sig… 

    …nature

Previously, key signature selection could return an error even when a valid signature was available.
This PR fixes the issue by returning the valid signature and ignoring errors from invalid ones if at least one valid signature is found.
    @lubux
    lubux authored May 20, 2025
    Configuration menu
    Copy the full SHA
    a994e32 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2025

  1. fix(clearsign): Enforce acceptable hash functions in clearsign

    @lubux
    lubux committed May 21, 2025
    Configuration menu
    Copy the full SHA
    244eb1c View commit details
    Browse the repository at this point in the history

  2. feat(clearsign): Write complete legacy hash header

    @lubux
    lubux committed May 21, 2025
    Configuration menu
    Copy the full SHA
    9cd4c3a View commit details
    Browse the repository at this point in the history

  3. Merge pull request #281 from ProtonMail/fix/clearsign-check-hash 

    This PR fixes clearsign to only allow hash functions that are allowed for the particular signing algorithm.
    @lubux
    lubux authored May 21, 2025
    Configuration menu
    Copy the full SHA
    e1ea40e View commit details
    Browse the repository at this point in the history

Commits on May 22, 2025

  1. feat: Allow to set a decompressed size limit

    @lubux
    lubux committed May 22, 2025
    Configuration menu
    Copy the full SHA
    d664700 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #285 from ProtonMail/feat/decompression-size-limit 

    This commit adds a config option that allows an application to set a decompressed data size limit.
    @lubux
    lubux authored May 22, 2025
    Configuration menu
    Copy the full SHA
    3c60603 View commit details
    Browse the repository at this point in the history

  3. feat(v1): Only allow acceptable hashes when writing signatures

    @lubux
    lubux committed May 22, 2025
    Configuration menu
    Copy the full SHA
    a9af95c View commit details
    Browse the repository at this point in the history

  4. Merge pull request #286 from ProtonMail/feat/v1-api-enforce-signature… 

    …-hashes

RFC 9580 mandates the use of specific hash algorithms for certain signature algorithms. While the v2 API already enforces these restrictions, this PR ports the same logic to the v1 API to ensure that invalid or non-compliant data cannot be written.
    @lubux
    lubux authored May 22, 2025
    Configuration menu
    Copy the full SHA
    3b22d85 View commit details
    Browse the repository at this point in the history
Loading