Skip to content

ipfs@0.41 update: option 2 #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ipfs@0.41 update: option 2 #383

wants to merge 1 commit into from

Conversation

zebateira
Copy link
Contributor

@zebateira zebateira commented Feb 17, 2020 •
edited
Loading

Second option for dealing with the new js ipfs api that always returns iterables.
This second approach uses the it-all package from @achingbrain.

Screen Shot 2020-02-17 at 7 06 01 PM

  • A bit more clean but it might be confusing for users to understand where to use the all function

See original WIP PR: #381

@zebateira zebateira mentioned this pull request Feb 17, 2020
Merged
@zebateira zebateira force-pushed the fix/js-ipfs-0.41-update-option-2 branch from dc44088 to 94d3b6a Compare February 17, 2020 15:33
@zebateira zebateira closed this Feb 17, 2020
@zebateira zebateira deleted the fix/js-ipfs-0.41-update-option-2 branch February 18, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zebateira