Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate grid subsets for faces and key points (like X-points, strike points) #6

Closed
15 tasks done
eldond opened this issue Aug 31, 2023 · 10 comments
Closed
15 tasks done
Assignees

Comments

@eldond
Copy link
Collaborator

eldond commented Aug 31, 2023

  • x_points: 6 (nodes defining X-points)
  • core_cut: 7 (y-aligned faces inside the separatrix connecting to the active x-point)
    • This tells us where the cut defined by b2fgmtry was
    • If extrapolated, this curve would pass through the magnetic axis
  • PFR_cut: 8 (y-aligned faces inside the private flux region connecting to the active x-point)
    • Another b2fgmtry cut
    • This is the boundary between inner and outer divertors
  • outer_throat: 9 (y-aligned faces in the outer SOL connecting to the active X-point)
    • This is the boundary between SOL and outer divertor
  • inner_throat: 10
  • outer_midplane: 11 (y-aligned faces connecting to the node closest to the outer midplane on the separatrix)
  • inner_midplane: 12
  • outer_target: 13 (y-aligned faces defining the outer target)
  • inner_target: 14
  • core_boundary: 15 (innermost x-aligned faces)
    • the inner edge of the mesh; boundary between computation region and blank spot in the core
  • separatrix: 16 (x-aligned faces defining the active separatrix)
  • outer_mid_plane_separatrix: 101 (point on active separatrix at outer midplane)
    • Intersection of 11 with 16
  • inner_mid_plane_separatrix: 102
    • Intersection of 12 with 16
  • outer_target_separatrix: 103 (point on active separatrix at outer [divertor] target)
    • Intersection of 13 with 16
  • inner_target_separatrix: 104
    • Intersection of 14 with 16
@anchal-physics
Copy link
Collaborator

a994b4d Added x_points

@anchal-physics
Copy link
Collaborator

8e399d0 Added faces and core_cut

@anchal-physics
Copy link
Collaborator

760ef7b Added pfr_cut, throats, targets, fixed speed issue

@anchal-physics
Copy link
Collaborator

3d5972b Finished all but midplane subsets

@anchal-physics
Copy link
Collaborator

62371f2 Added inner and outer midplane subsets

@anchal-physics
Copy link
Collaborator

anchal-physics commented Sep 19, 2023

With new visualitation through GGDUtils, it has come to light that some subsets are not created properly:

Image
SOLPSgridVisualization.pdf

Issues to fix:

  • Inner throat edge is wrongly identified.
  • Outer midplane are y-aligned edges but is that what we really wanted?
  • Inner midplane did not get populated.

@eldond Please add more issues to fix if you can spot them.

@anchal-physics
Copy link
Collaborator

Actually, the inner midplane did not get populated because jxi index is not provided in our sample SOLPS files. So I'm marking this resolved. It will probably show the same feature as y-aligned (poliodal direction aligned) edges which is what is written in the OMAS data structure schema webpage. Is that a typo there?

@anchal-physics
Copy link
Collaborator

3062359 Inner throat edge issue fixed.

Image

@anchal-physics
Copy link
Collaborator

3523eda

Image

That was my bad. I got confused about y-aligned edge definition. I have corrected the outer midplane and inner midplane generation. The inner midplane would be populated if jxi information is provided in b2mn.dat. We can close this issue again now.

@eldond
Copy link
Collaborator Author

eldond commented Sep 19, 2023

Beautiful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants