Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply scrolling / skeleton loading effect to header mobile menu overlay background #77

Open
thescientist13 opened this issue Aug 5, 2024 · 2 comments
Labels
enhancement New feature or request fast follow Carryovers from the launch milestone good first issue Good for newcomers

Comments

@thescientist13
Copy link
Member

Summary

As part of #73 we refactored the Header navigation to use the browser's popover API and all but the original background scrolling / skeleton loader effect was preserved, so this issue is to track restoring that.

mobile-menu-background-scroll.mov

Details

Not sure if it's just an issue with popover not fully supporting all theming options yet?

Also, would be nice to confirm why our implementation came with a [default border style] we had to override](https://github.com/ProjectEvergreen/www.greenwoodjs.dev/pull/73/files#diff-bf1b9c049433cad724ac18bbe7a27b3f0493837d217fd300219ff8d0a080758cR47)? 🤔

@DevLab2425
Copy link
Contributor

DevLab2425 commented Oct 15, 2024

@thescientist13
I'm not able to replicate this on the current "live" version -- https://super-tapioca-5987ce.netlify.app/

Tested in Chrome, FF, and Safari and all seem to allow for the menu popover to be opened, and the page to scroll. Maybe I'm misunderstanding the issue?

@thescientist13
Copy link
Member Author

thescientist13 commented Oct 15, 2024

Yeah, sorry about that confusion.

The desire here was to recapture the effect of the body scrolling underneath the popover with the effect of scrolling over the text underneath.

That said, I wonder if this is just a confusing UX, to be scrolling the page while the popover is up? I think for the SideNav component I set overflow-y: hidden on the body when it's open.
https://github.com/ProjectEvergreen/www.greenwoodjs.dev/blob/main/src/layouts/guides.html#L16

Maybe we should do that here too?

@thescientist13 thescientist13 added the fast follow Carryovers from the launch milestone label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fast follow Carryovers from the launch milestone good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants