Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Delete Name check #51

Open
ajlacey opened this issue Dec 7, 2021 · 0 comments
Open

Device Delete Name check #51

ajlacey opened this issue Dec 7, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ajlacey
Copy link
Member

ajlacey commented Dec 7, 2021

Session.py deleteDevice() does not currently validate that the device name is in the topology. This check should be added to present the front end with an error message if a non-existent device is attempted to be deleted.

This issue is low priority as the input is currently constrained by the front-end to only be able to delete devices that are already created. Additionally, if the device name is invalid, then the function will execute and present a new (but unchanged) topology to the front end. This results in more work, while still leave a valid topology for the user.

@ajlacey ajlacey added the enhancement New feature or request label Dec 7, 2021
@ajlacey ajlacey self-assigned this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant