You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the workflows in our CI perform flake8 checks on the python code in order to produce lint errors. However, these checks only execute on the toynet-flask/flasksrc directory. Expand these lint checks to also address the following folders and resolve any lint errors that arise:
toynet-flask/tests
toynet-flask/toynet_mininet/flasksrc
toynet-flask/toynet_mininet/tests
toynet-flask/toynet_mininet/util
toynet-flask/toynet_mininet/toynet
Additionally, update the Makefiles so that a call to make lint will run the appropriate lint checks locally; the README should also be updated to show that the developer needs to install flake8 via pip3 for this functionality.
The text was updated successfully, but these errors were encountered:
Currently the workflows in our CI perform
flake8
checks on the python code in order to produce lint errors. However, these checks only execute on thetoynet-flask/flasksrc
directory. Expand these lint checks to also address the following folders and resolve any lint errors that arise:toynet-flask/tests
toynet-flask/toynet_mininet/flasksrc
toynet-flask/toynet_mininet/tests
toynet-flask/toynet_mininet/util
toynet-flask/toynet_mininet/toynet
Additionally, update the
Makefile
s so that a call tomake lint
will run the appropriate lint checks locally; theREADME
should also be updated to show that the developer needs to installflake8
viapip3
for this functionality.The text was updated successfully, but these errors were encountered: