Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI Linter #31

Open
blazebissar opened this issue Oct 5, 2021 · 0 comments
Open

Update CI Linter #31

blazebissar opened this issue Oct 5, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@blazebissar
Copy link
Contributor

Currently the workflows in our CI perform flake8 checks on the python code in order to produce lint errors. However, these checks only execute on the toynet-flask/flasksrc directory. Expand these lint checks to also address the following folders and resolve any lint errors that arise:

  • toynet-flask/tests
  • toynet-flask/toynet_mininet/flasksrc
  • toynet-flask/toynet_mininet/tests
  • toynet-flask/toynet_mininet/util
  • toynet-flask/toynet_mininet/toynet

Additionally, update the Makefiles so that a call to make lint will run the appropriate lint checks locally; the README should also be updated to show that the developer needs to install flake8 via pip3 for this functionality.
@blazebissar blazebissar added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blazebissar