-
Notifications
You must be signed in to change notification settings - Fork 737
Add FL example with nvflare #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for some minor comments.
Thanks.
will this break our daily notebook tests? https://github.com/Project-MONAI/MONAI/runs/2644488450?check_suite_focus=true#step:6:11 the notebooks should run in the right order, could you rename the notebooks into "1-startup", "2-admin", "3-server", "4-client"? |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Hi @wyli , I modified the notebook names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, please see some comments inline
federated_learning/nvflare/spleen_example/config/dataset_part1.json
Outdated
Show resolved
Hide resolved
federated_learning/nvflare/spleen_example/config/dataset_part2.json
Outdated
Show resolved
Hide resolved
federated_learning/nvflare/spleen_example/config/config_fed_server.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
…tiple nodes) Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@@ -50,7 +50,7 @@ doChecks=true | |||
doRun=true | |||
autofix=false | |||
failfast=false | |||
pattern="-name \"*\"" | |||
pattern="-and -name '*' -and ! -wholename '*federated_learning*'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rijobro I exclude the federated_learning
folder by default, because it will likely to use multiple node, which is not feasible for the CI/CD at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, although I think the change should have really gone into our CI/CD .yaml files, rather than the runner itself.
* Add flare based trainers Signed-off-by: Yiheng Wang <vennw@nvidia.com> * Refactor the whole pipeline * Rename fl example * Update nvflare example Signed-off-by: Yiheng Wang <vennw@nvidia.com> * Fix pep8 errors Signed-off-by: Yiheng Wang <vennw@nvidia.com> * Specify nvflare version Signed-off-by: Yiheng Wang <vennw@nvidia.com> * Update copyrights and docker info Signed-off-by: Yiheng Wang <vennw@nvidia.com> * Use fixed monai docker version and add new lines Signed-off-by: Yiheng Wang <vennw@nvidia.com> * fixes readme Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update readme Signed-off-by: Wenqi Li <wenqil@nvidia.com> * by default exclude the federated learning related (often requires multiple nodes) Signed-off-by: Wenqi Li <wenqil@nvidia.com> * fixes a link Signed-off-by: Wenqi Li <wenqil@nvidia.com> Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yiheng Wang vennw@nvidia.com
Description
This PR shows an example of using a MONAI trainer and nvflare to do federated learning.
Status
Ready