Skip to content

Add FL example with nvflare #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 24, 2021
Merged

Add FL example with nvflare #189

merged 16 commits into from
May 24, 2021

Conversation

yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Apr 21, 2021

Signed-off-by: Yiheng Wang vennw@nvidia.com

Description

This PR shows an example of using a MONAI trainer and nvflare to do federated learning.

Status

Ready

@yiheng-wang-nv yiheng-wang-nv changed the title [WIP] Add flare based trainers [WIP] Add FL based trainers Apr 25, 2021
@yiheng-wang-nv yiheng-wang-nv deleted the add-flare-monai-example branch April 28, 2021 13:44
@yiheng-wang-nv yiheng-wang-nv restored the add-flare-monai-example branch May 21, 2021 09:29
yiheng-wang-nv and others added 2 commits May 21, 2021 17:29
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@yiheng-wang-nv yiheng-wang-nv changed the title [WIP] Add FL based trainers Add FL example with nvflare May 21, 2021
@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review May 21, 2021 09:34
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv requested review from Nic-Ma and wyli May 21, 2021 10:10
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for some minor comments.
Thanks.

@wyli
Copy link
Contributor

wyli commented May 22, 2021

will this break our daily notebook tests? https://github.com/Project-MONAI/MONAI/runs/2644488450?check_suite_focus=true#step:6:11 the notebooks should run in the right order, could you rename the notebooks into "1-startup", "2-admin", "3-server", "4-client"?

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Copy link
Contributor Author

will this break our daily notebook tests? https://github.com/Project-MONAI/MONAI/runs/2644488450?check_suite_focus=true#step:6:11 the notebooks should run in the right order, could you rename the notebooks into "1-startup", "2-admin", "3-server", "4-client"?

Hi @wyli , I modified the notebook names.

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please see some comments inline

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
wyli added 4 commits May 24, 2021 18:09
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
…tiple nodes)

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@@ -50,7 +50,7 @@ doChecks=true
doRun=true
autofix=false
failfast=false
pattern="-name \"*\""
pattern="-and -name '*' -and ! -wholename '*federated_learning*'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rijobro I exclude the federated_learning folder by default, because it will likely to use multiple node, which is not feasible for the CI/CD at the moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, although I think the change should have really gone into our CI/CD .yaml files, rather than the runner itself.

@wyli wyli merged commit 9261e7d into master May 24, 2021
@wyli wyli deleted the add-flare-monai-example branch May 24, 2021 17:32
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* Add flare based trainers

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* Refactor the whole pipeline

* Rename fl example

* Update nvflare example

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* Fix pep8 errors

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* Specify nvflare version

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* Update copyrights and docker info

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* Use fixed monai docker version and add new lines

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* fixes readme

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update readme

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* by default exclude the federated learning related (often requires multiple nodes)

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes a link

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants