Skip to content

Commit 195cccd

Browse files
authored
Read TaskPriorityClass from config (#872)
* Read TaskPriorityClass from config Signed-off-by: Victor Chang <vicchang@nvidia.com>
1 parent 0aca28d commit 195cccd

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

src/Common/Configuration/TaskManagerConfiguration.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,5 +74,8 @@ public class ArgoPluginArguments
7474

7575
[ConfigurationKeyName("messageSenderContainerMemoryLimit")]
7676
public string MessageSenderContainerMemoryLimit { get; set; } = "500Mi";
77+
78+
[ConfigurationKeyName("taskPriorityClass")]
79+
public string TaskPriorityClass { get; set; } = string.Empty;
7780
}
7881
}

src/TaskManager/Plug-ins/Argo/ArgoPlugin.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ private async Task<Workflow> BuildWorkflowWrapper(CancellationToken cancellation
432432
private void ProcessTaskPluginArguments(Workflow workflow)
433433
{
434434
Guard.Against.Null(workflow, nameof(workflow));
435-
var priorityClassName = Event.GetTaskPluginArgumentsParameter(ArgoParameters.TaskPriorityClassName) ?? "standard";
435+
var priorityClassName = Event.GetTaskPluginArgumentsParameter(ArgoParameters.TaskPriorityClassName) ?? _options.Value.TaskManager.ArgoPluginArguments.TaskPriorityClass;
436436

437437
foreach (var template in workflow.Spec.Templates)
438438
{

src/TaskManager/TaskManager/appsettings.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@
5959
"messageGeneratorContainerCpuLimit": "1",
6060
"messageGeneratorContainerMemoryLimit": "500Mi",
6161
"messageSenderContainerCpuLimit": "1",
62-
"messageSenderContainerMemoryLimit": "500Mi"
62+
"messageSenderContainerMemoryLimit": "500Mi",
63+
"taskPriorityClass": ""
6364
},
6465
"argoExitHookSendMessageContainerImage": "ghcr.io/project-monai/monai-deploy-task-manager-callback:0.2.0-beta.211"
6566
},

tests/UnitTests/TaskManager.Argo.Tests/ArgoPluginTestBase.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ public ArgoPluginTestBase()
100100
Options.Value.TaskManager.ArgoPluginArguments.MessageGeneratorContainerMemoryLimit = MessageGeneratorContainerMemoryLimit;
101101
Options.Value.TaskManager.ArgoPluginArguments.MessageSenderContainerCpuLimit = MessageSenderContainerCpuLimit;
102102
Options.Value.TaskManager.ArgoPluginArguments.MessageSenderContainerMemoryLimit = MessageSenderContainerMemoryLimit;
103+
Options.Value.TaskManager.ArgoPluginArguments.TaskPriorityClass = "standard";
103104
}
104105
}
105106
}

0 commit comments

Comments
 (0)