Temporarily Restrict setuptools Version to 79.0.1 #8441
Conversation
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
I tried merge the change in this pr: https://github.com/Project-MONAI/MONAI/pull/8436/files, otherwise the ci can not pass. cc @ericspod |
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily restricts the setuptools version to 79.0.1 to maintain compatibility with the current setup, while also updating torch version and target Python versions in various project files.
- Updated requirements-min.txt to restrict setuptools for Python 3.12 and above
- Revised torch dependency and target Python versions in pyproject.toml and workflow files
- Made a type adjustment in the ddpm scheduler for variance
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| requirements-min.txt | Updated setuptools dependency to enforce an upper limit for Python 3.12+ |
| pyproject.toml | Revised torch version requirement and updated black's target Python versions |
| monai/networks/schedulers/ddpm.py | Changed variance from an integer to a tensor with type annotation |
| .github/workflows/pythonapp.yml | Updated torch version in installation steps |
| .github/workflows/pythonapp-min.yml | Adjusted the pytorch version matrix with a FIXME comment |
Files not reviewed (2)
- docs/requirements.txt: Language not supported
- setup.cfg: Language not supported
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
Looks fine to me, we can merge the previous PR if there's anything included in these changes.
We need fixed the version of setuptools to fix the ci issue in this pr: https://github.com/Project-MONAI/MONAI/pull/8436/files |
Sure we'll merge this one and I'll handle the merging for my PR. |
|
/build |
|
Temporarily set min-dep-pytorch (latest) as not required in this PR. |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
/build |
| @@ -1,3 +1,2 @@ | |||
| torch>=2.3.0; sys_platform != 'win32' | |||
| torch>=2.4.1; sys_platform == 'win32' | |||
| torch>=2.4.1, <2.7.0 | |||
There was a problem hiding this comment.
@ericspod Was it intentional to also bump the minimum torch on non-Windows platforms from 2.3.0 to 2.4.1?
There was a problem hiding this comment.
It was yes, we intend to support the previous three versions of Pytorch so 2.3 fell out of official support for MONAI.
3 participants
workaround for #8439
Description
This PR temporarily restricts the setuptools version to 79.0.1 to maintain compatibility with our current setup. In future updates, we need to review and update our setup configurations to accommodate later versions of setuptools.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.