-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Removed outdated torch version checks from transform functions
#8359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed outdated torch version checks from transform functions
#8359
Conversation
ericspod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good, if we're through the tests and blossom we can merge, thanks!
|
The DCO issue should be fixable through the instructions it gives for a remedial commit. |
|
@ericspod Thanks for the review. After a couple of attempts I managed to fix the DCO :D |
|
/build |
KumoLiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix, LGTM.
Hi @nkaenzig we weren't planning a release soon since we're working on things for a proper 1.5 release. We've removed things already that shouldn't go until 1.5 so a patch release now may be a problem. If you want the fixes to use immediately you can install MONAI from the git repo using pip or install |
…ject-MONAI#8359) Fixes Project-MONAI#8348 ### Description Support for `torch` versions prior to `1.13` has been dropped, so those `1.8` version checks are not required anymore. Furthermore, as reported in the issue description, those checks led to unstable behaviour when using certain transforms in data pipelines. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Nicolas Kaenzig <nkaenzig@gmail.com> Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Fixes #8348
Description
Support for
torchversions prior to1.13has been dropped, so those1.8version checks are not required anymore. Furthermore, as reported in the issue description, those checks led to unstable behaviour when using certain transforms in data pipelines.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.