Solves path problem in test_bundle_trt_export.py #8357
Conversation
There was a problem with this test after the else statement was removed, leading to a onnx_model not defined error
|
/build |
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
Looks good to me, if you could do the DCO remediation and blossom passes we're good to go.
|
Hi @garciadias, could you please try the guide here to resolve the DCO issue? Thanks! |
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: ba56a6d I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: da29d2f I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 93f16db Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com> Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
- Introduced a new `dict_product` function to create combinations of input parameters. - Updated test cases to use the new utility for generating shape and input type combinations. - Cleaned up code by removing old nested loops in favor of the new function.
|
The DCO issue is still unresolved, and it's not clear if it's due to inappropriate indentation. If you can add sigh off to every commit later, you might be able to avoid the such kind of issue. |
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: ba56a6d I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: da29d2f I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 93f16db Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com> Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
- Introduced a new `dict_product` function to create combinations of input parameters. - Updated test cases to use the new utility for generating shape and input type combinations. - Cleaned up code by removing old nested loops in favor of the new function.
… into 8354_fix_test_bundle_trt_export
I am sorry about that. I think it is fixed now. I set it up to sign every commit, but it's not working correctly. I will solve this to make sure all commits are signed from now on. |
Great, it fixed for yesterday's four commits. But just now you push two commits without sighoff. The DCO will check each commit in the PR. :) |
|
/build |
Fixes Project-MONAI#8354 ### Description Fixes path on test that is only run on special conditions. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Can-Zhao <volcanofly@gmail.com>
3 participants
Fixes #8354 #8353
Description
Fixes path on test that is only run on special conditions.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.