Inferer modification - save_intermediates clashes with latent shape adjustment in latent diffusion inferers #8343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fusionInferer when save_intermediates was off but there's need to pad and crop latent space. Signed-off-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk>
…fusionInferer when save_intermediates was off but there's need to pad and crop latent space. Signed-off-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk>
Member
|
Thanks for the fix, could we add a unit test to capture this behaviour? We should have one test at least that would fail without this fix but works with it I think. |
KumoLiu
approved these changes
Feb 18, 2025
Contributor
KumoLiu
left a comment
KumoLiu
left a comment
There was a problem hiding this comment.
Thanks for the fix, LGTM.
added 4 commits
February 18, 2025 08:01
Signed-off-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk>
Signed-off-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk>
Signed-off-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk>
KumoLiu
reviewed
Feb 18, 2025
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Contributor
|
/build |
added 2 commits
February 18, 2025 10:53
Signed-off-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk>
Contributor
|
/build |
ericspod
approved these changes
Feb 18, 2025
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
Mar 10, 2025
…djustment in latent diffusion inferers (Project-MONAI#8343) Fixes Project-MONAI#8334 ### Description There was an if save_intermediates missing in the code that was trying to run crop of the latent spaces on the sample function of the Latent Diffusion Inferers (normal one and ControlNet one) even when intermediates aren't created. ### Types of changes - [x] Non-breaking change (fix or new feature that would not break existing functionality). --------- Signed-off-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: Virginia Fernandez <virginia.fernandez@kcl.ac.uk> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8334
Description
There was an if save_intermediates missing in the code that was trying to run crop of the latent spaces on the sample function of the Latent Diffusion Inferers (normal one and ControlNet one) even when intermediates aren't created.
Types of changes