Add platform-specific constraints to setup.cfg #8260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
ericspod
reviewed
Dec 9, 2024
Member
|
We do have an issue it seems in that our CICD uses Windows 10 Server only and no version of 11, perhaps that needs to be addressed as well. I commented on the other packages being excluded, I'd rather exclude these for 11 specifically to support 10 users but if that can't be done and they need exclusion then I'm good here. |
ericspod
approved these changes
Dec 9, 2024
Contributor
Author
|
/build |
3 similar comments
Contributor
Author
|
/build |
Contributor
Author
|
/build |
Contributor
Author
|
/build |
aylward
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8258
Description
Include platform_system conditions for dependencies in setup.cfg
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.