Skip to content

SwinUNETR refactor to accept additional parameters #8212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2024
Merged

SwinUNETR refactor to accept additional parameters #8212

merged 4 commits into from
Nov 25, 2024

Conversation

@EloiNavet
Copy link
Contributor

@EloiNavet EloiNavet commented Nov 15, 2024

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • [ ] New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.

KumoLiu
KumoLiu approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr, looks good to me.
Please sign-off to resolve the DCO issue: https://github.com/Project-MONAI/MONAI/pull/8212/checks?check_run_id=33058478464

@KumoLiu KumoLiu requested review from Nic-Ma and ericspod November 18, 2024 03:51
EloiNavet and others added 3 commits November 18, 2024 09:19
@EloiNavet
DCO Remediation Commit for Eloi Navet <eloi.navet@labri.fr>
4cfa470 
I, Eloi Navet eloi.navet@labri.fr, hereby add my Signed-off-by to this commit: 08f3ce3

Signed-off-by: Eloi Navet eloi.navet@labri.fr
@EloiNavet
DCO Remediation Commit for Eloi Navet <eloi.navet@labri.fr>
8f31ec9 
I, Eloi Navet <eloi.navet@labri.fr>, hereby add my Signed-off-by to this commit: 08f3ce3
I, Eloi Navet <eloi.navet@labri.fr>, hereby add my Signed-off-by to this commit: 4cfa470

Signed-off-by: Eloi Navet <eloi.navet@labri.fr>
@KumoLiu
Merge branch 'dev' into swin-unetr-extended
a73dbd1
@KumoLiu
Copy link
Contributor

KumoLiu commented Nov 25, 2024

/build

@KumoLiu KumoLiu enabled auto-merge (squash) November 25, 2024 05:49
@KumoLiu KumoLiu merged commit 3ee4cd2 into Project-MONAI:dev Nov 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EloiNavet @KumoLiu