Skip to content

Remove deprecated args and class for v1.4 #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 16, 2024
Merged

Remove deprecated args and class for v1.4 #8079

merged 5 commits into from
Sep 16, 2024

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 11, 2024

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
Merge branch 'dev' into deprecated
774c95a
@KumoLiu
remove deprecated
0031f2d 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested review from Nic-Ma and ericspod September 11, 2024 10:33
@KumoLiu
fix mypy
7bb3f51 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Merge branch 'deprecated' of https://github.com/KumoLiu/MONAI into de…
3190f21 
…precated
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 11, 2024

/build

RahulVadisetty91
RahulVadisetty91 reviewed Sep 13, 2024
View reviewed changes
Copy link

@RahulVadisetty91 RahulVadisetty91 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0999k

Correct or remove the last line of the docstring as the default is None

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 16, 2024

/build

2 similar comments
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 16, 2024

/build

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 16, 2024

/build

@KumoLiu KumoLiu merged commit 3282e45 into Project-MONAI:dev Sep 16, 2024
@KumoLiu KumoLiu deleted the deprecated branch September 16, 2024 04:48
@KumoLiu KumoLiu mentioned this pull request Sep 25, 2024
Closed
31 tasks
@KumoLiu KumoLiu mentioned this pull request Apr 11, 2025
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

+1 more reviewer

@RahulVadisetty91 RahulVadisetty91 RahulVadisetty91 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KumoLiu @ericspod @RahulVadisetty91