7994-enhance-mlpblock #7995
Merged
7994-enhance-mlpblock #7995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
yiheng-wang-nv
commented
Aug 6, 2024
|
@yiheng-wang-nv, thanks for the pr, overall looks good to me. |
KumoLiu
approved these changes
Aug 6, 2024
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
|
/build |
2 similar comments
|
/build |
|
/build |
@yiheng-wang-nv please help take a look at the ci error. |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
|
/build |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
…to enhance-mlpblock
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
/build |
|
/build |
5 tasks
KumoLiu
pushed a commit
to Project-MONAI/tutorials
that referenced
this pull request
Aug 12, 2024
Fixes # . ### Description This PR is used to update the path of morphological path according to MONAI core changes: Project-MONAI/MONAI#7995. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7994 .
Description
The current implementation does not support tuple input of "GEGLU" since it only change the out features of the first linear layer when the input is a string of "GEGLU".
This PR enhances it, and also enable "vista3d" mode to support #7987
Tests are added to cover the changes.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.