Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Incompatible types in assignment issue #7950

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Fix Incompatible types in assignment issue #7950

merged 5 commits into from
Jul 25, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jul 25, 2024

Fixes #7947

Description

Add type ignore in several redefinitions cases

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#7947
918219b 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu marked this pull request as ready for review July 25, 2024 13:14
pre-commit-ci bot and others added 2 commits July 25, 2024 13:15
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
49468ba 
for more information, see https://pre-commit.ci
@KumoLiu
fix flake8
2551a40 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 25, 2024

/build

@KumoLiu KumoLiu requested review from ericspod and Nic-Ma July 25, 2024 13:25
@KumoLiu
minor fix
be4be49 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
minor fix
b77f193 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
KumoLiu
KumoLiu commented Jul 25, 2024
View reviewed changes
monai/auto3dseg/analyzer.py Show resolved Hide resolved
monai/metrics/panoptic_quality.py Show resolved Hide resolved
monai/metrics/rocauc.py Show resolved Hide resolved
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 25, 2024

Hi @ericspod, I have updated where it can avoid using ignore and leave several places not worked. Could you please help review it again? Thanks!

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 25, 2024

/build

ericspod
ericspod approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to resolve the blocking issue. Thanks!

@ericspod ericspod enabled auto-merge (squash) July 25, 2024 15:32
@ericspod ericspod merged commit 3f0c768 into Project-MONAI:dev Jul 25, 2024
28 checks passed
@KumoLiu KumoLiu deleted the fix-mypy branch July 30, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible types in assignment issue
2 participants
@KumoLiu @ericspod