Remove use of deprecated python 3.12 strtobool #7900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmjohnson
force-pushed
the
python312-no-distutils
branch
3 times, most recently
from
44f555a
to
4f76238
Compare
distutils is not available in python 3.12, so a substitute is needed for the strtobool code. Use same resolution as implemented by the ITK project. Signed-off-by: Hans Johnson <hans-johnson@uiowa.edu>
hjmjohnson
force-pushed
the
python312-no-distutils
branch
from
4f76238
to
87862f0
Compare
Due to the removal of the long-deprecated pkgutil.ImpImporter class a newer version of setuptools that provides this capability. for Python 3.12. This resolves: monai.utils.module.OptionalImportError: Please install mlflow before using MLFlowHandler. (module 'pkgutil' has no attribute 'ImpImporter'). Signed-off-by: Hans Johnson <hans-johnson@uiowa.edu>
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils is not available in python 3.12, so a substitute is needed for the strtobool code.
Fixes #7899
Description
Replace distutils strtobool with local _strtobool version.
Types of changes
./runtests.sh --quick --unittests --disttests.