Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating a Tailored Auto-Encoder Model into Generative Model Application #7861

Merged
merged 49 commits into from
Jul 1, 2024

Conversation

dongyang0122
Copy link
Collaborator

Fixes #7858.

Description

Integrating a tailored auto-encoder model into the generative model application to improve the production of high-dimensional 3D images, specifically sized at 512 x 512 x 512.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
@dongyang0122 dongyang0122 self-assigned this Jun 18, 2024
dongyang0122 and others added 12 commits June 19, 2024 15:10
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
@dongyang0122 dongyang0122 marked this pull request as ready for review June 21, 2024 17:08
@ericspod
Copy link
Member

The requirements for this app aren't being installed by the tests, this is why they are failing. The generative models repo is being integrated into Core by @virginiafdez currently, shall we wait for that to complete and then we can eliminate the requirement here for the external repo? Thanks!

@dongyang0122
Copy link
Collaborator Author

Hi @Nic-Ma @KumoLiu @ericspod @yiheng-wang-nv , the PR is dependent on another monai related project. I am not sure how to pass the some tests without installing the package. Thanks.

@dongyang0122
Copy link
Collaborator Author

Hi @ericspod, we are currently preparing to release a new MONAI feature within the next few days. Initially, we may need to enable this application, followed by integrating the changes once another pull request is ready for incorporation.

dongyang0122 and others added 6 commits June 21, 2024 17:37
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
@KumoLiu KumoLiu requested a review from ericspod June 27, 2024 13:42
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
@dongyang0122
Copy link
Collaborator Author

dongyang0122 commented Jun 27, 2024

I am not sure what the following error (premerge / flake8-py3 (codeformat) (pull_request) Failing after 3m) is from. This is not from my scripts.

tests/test_pad_collation.py:116:12: E721 Use is and is not for type comparisons, or isinstance() for isinstance checks
|
114 | self.assertTrue(len(set(shapes)) > 1) # inverted shapes must be different because of random xforms
115 |
116 | if t_type == dict:
| ^^^^^^^^^^^^^^ E721
117 | batch_inverse = BatchInverseTransform(dataset.transform, loader)
118 | for data in loader:
|

Found 3 errors.
Check failed!
Please run auto style fixes: ./runtests.sh --autofix
Error: Process completed with exit code 1.

Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
@KumoLiu
Copy link
Contributor

KumoLiu commented Jun 28, 2024

I am not sure what the following error (premerge / flake8-py3 (codeformat) (pull_request) Failing after 3m) is from. This is not from my scripts.

tests/test_pad_collation.py:116:12: E721 Use is and is not for type comparisons, or isinstance() for isinstance checks | 114 | self.assertTrue(len(set(shapes)) > 1) # inverted shapes must be different because of random xforms 115 | 116 | if t_type == dict: | ^^^^^^^^^^^^^^ E721 117 | batch_inverse = BatchInverseTransform(dataset.transform, loader) 118 | for data in loader: |

Found 3 errors. Check failed! Please run auto style fixes: ./runtests.sh --autofix Error: Process completed with exit code 1.

Hi @dongyang0122, you can merge dev to solve the error, thanks!

Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
@dongyang0122
Copy link
Collaborator Author

Shall we proceed if no further questions? Thanks. @KumoLiu @mingxin-zheng @ericspod

@ericspod
Copy link
Member

Shall we proceed if no further questions? Thanks. @KumoLiu @mingxin-zheng @ericspod

I'm good if others are.

@KumoLiu
Copy link
Contributor

KumoLiu commented Jul 1, 2024

/build

@mingxin-zheng
Copy link
Contributor

I have no other comments now and okay to merge it as long as the tests pass. Thanks!

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor

KumoLiu commented Jul 1, 2024

/build

Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
@KumoLiu KumoLiu merged commit 2c7a26b into Project-MONAI:dev Jul 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Tailored Model Implementations into Generative Model Application
4 participants