-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating a Tailored Auto-Encoder Model into Generative Model Application #7861
Integrating a Tailored Auto-Encoder Model into Generative Model Application #7861
Conversation
for more information, see https://pre-commit.ci
…22/MONAI into fix-issue-7858-add-ae
for more information, see https://pre-commit.ci
…22/MONAI into fix-issue-7858-add-ae
The requirements for this app aren't being installed by the tests, this is why they are failing. The generative models repo is being integrated into Core by @virginiafdez currently, shall we wait for that to complete and then we can eliminate the requirement here for the external repo? Thanks! |
Hi @Nic-Ma @KumoLiu @ericspod @yiheng-wang-nv , the PR is dependent on another monai related project. I am not sure how to pass the some tests without installing the package. Thanks. |
Hi @ericspod, we are currently preparing to release a new MONAI feature within the next few days. Initially, we may need to enable this application, followed by integrating the changes once another pull request is ready for incorporation. |
for more information, see https://pre-commit.ci
…22/MONAI into fix-issue-7858-add-ae
…22/MONAI into fix-issue-7858-add-ae
I am not sure what the following error (premerge / flake8-py3 (codeformat) (pull_request) Failing after 3m) is from. This is not from my scripts. tests/test_pad_collation.py:116:12: E721 Use Found 3 errors. |
Hi @dongyang0122, you can merge dev to solve the error, thanks! |
Shall we proceed if no further questions? Thanks. @KumoLiu @mingxin-zheng @ericspod |
I'm good if others are. |
/build |
I have no other comments now and okay to merge it as long as the tests pass. Thanks! |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
/build |
…22/MONAI into fix-issue-7858-add-ae
Fixes #7858.
Description
Integrating a tailored auto-encoder model into the generative model application to improve the production of high-dimensional 3D images, specifically sized at 512 x 512 x 512.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.