Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed misguiding weight mode documentation #7746

Merged
merged 1 commit into from
May 7, 2024

Conversation

simojens
Copy link
Contributor

@simojens simojens commented May 7, 2024

Description

DeepSupervisionLoss has a small typo in the documentation for 'exp' weight mode. The correct weights for this mode should be starting at 1, not 0 and then decrease by power of two. Might be worth fixing as it made me check the source code.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Simon Jensen <61684806+simojens@users.noreply.github.com>
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot thanks!

@ericspod ericspod enabled auto-merge (squash) May 7, 2024 13:29
@KumoLiu
Copy link
Contributor

KumoLiu commented May 7, 2024

/build

@ericspod ericspod merged commit ecaf5a1 into Project-MONAI:dev May 7, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants